Skip to content

Commit 86a9bb5

Browse files
committed
ALSA: usb-audio: Drop CONFIG_PM ifdefs
Practically seen, CONFIG_PM is almost mandatory. Let's drop the ugly ifdef lines and simplify the code. Link: https://lore.kernel.org/r/20211202084053.18201-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 82cd3ba commit 86a9bb5

6 files changed

Lines changed: 0 additions & 27 deletions

File tree

sound/usb/card.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -987,8 +987,6 @@ void snd_usb_unlock_shutdown(struct snd_usb_audio *chip)
987987
wake_up(&chip->shutdown_wait);
988988
}
989989

990-
#ifdef CONFIG_PM
991-
992990
int snd_usb_autoresume(struct snd_usb_audio *chip)
993991
{
994992
int i, err;
@@ -1100,11 +1098,6 @@ static int usb_audio_resume(struct usb_interface *intf)
11001098
atomic_dec(&chip->active); /* allow autopm after this point */
11011099
return err;
11021100
}
1103-
#else
1104-
#define usb_audio_suspend NULL
1105-
#define usb_audio_resume NULL
1106-
#define usb_audio_resume NULL
1107-
#endif /* CONFIG_PM */
11081101

11091102
static const struct usb_device_id usb_audio_ids [] = {
11101103
#include "quirks-table.h"

sound/usb/mixer.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3629,7 +3629,6 @@ void snd_usb_mixer_disconnect(struct usb_mixer_interface *mixer)
36293629
mixer->disconnected = true;
36303630
}
36313631

3632-
#ifdef CONFIG_PM
36333632
/* stop any bus activity of a mixer */
36343633
static void snd_usb_mixer_inactivate(struct usb_mixer_interface *mixer)
36353634
{
@@ -3711,7 +3710,6 @@ int snd_usb_mixer_resume(struct usb_mixer_interface *mixer)
37113710

37123711
return snd_usb_mixer_activate(mixer);
37133712
}
3714-
#endif
37153713

37163714
void snd_usb_mixer_elem_init_std(struct usb_mixer_elem_list *list,
37173715
struct usb_mixer_interface *mixer,
@@ -3720,7 +3718,5 @@ void snd_usb_mixer_elem_init_std(struct usb_mixer_elem_list *list,
37203718
list->mixer = mixer;
37213719
list->id = unitid;
37223720
list->dump = snd_usb_mixer_dump_cval;
3723-
#ifdef CONFIG_PM
37243721
list->resume = restore_mixer_value;
3725-
#endif
37263722
}

sound/usb/mixer.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,8 @@ void snd_usb_mixer_elem_init_std(struct usb_mixer_elem_list *list,
118118
int snd_usb_mixer_vol_tlv(struct snd_kcontrol *kcontrol, int op_flag,
119119
unsigned int size, unsigned int __user *_tlv);
120120

121-
#ifdef CONFIG_PM
122121
int snd_usb_mixer_suspend(struct usb_mixer_interface *mixer);
123122
int snd_usb_mixer_resume(struct usb_mixer_interface *mixer);
124-
#endif
125123

126124
int snd_usb_set_cur_mix_value(struct usb_mixer_elem_info *cval, int channel,
127125
int index, int value);

sound/usb/mixer_quirks.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3280,7 +3280,6 @@ int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer)
32803280
return err;
32813281
}
32823282

3283-
#ifdef CONFIG_PM
32843283
void snd_usb_mixer_resume_quirk(struct usb_mixer_interface *mixer)
32853284
{
32863285
switch (mixer->chip->usb_id) {
@@ -3289,7 +3288,6 @@ void snd_usb_mixer_resume_quirk(struct usb_mixer_interface *mixer)
32893288
break;
32903289
}
32913290
}
3292-
#endif
32933291

32943292
void snd_usb_mixer_rc_memory_change(struct usb_mixer_interface *mixer,
32953293
int unitid)

sound/usb/mixer_quirks.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ void snd_usb_mixer_fu_apply_quirk(struct usb_mixer_interface *mixer,
1414
struct usb_mixer_elem_info *cval, int unitid,
1515
struct snd_kcontrol *kctl);
1616

17-
#ifdef CONFIG_PM
1817
void snd_usb_mixer_resume_quirk(struct usb_mixer_interface *mixer);
19-
#endif
2018

2119
#endif /* SND_USB_MIXER_QUIRKS_H */
2220

sound/usb/power.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,7 @@ struct snd_usb_power_domain *
2121
snd_usb_find_power_domain(struct usb_host_interface *ctrl_iface,
2222
unsigned char id);
2323

24-
#ifdef CONFIG_PM
2524
int snd_usb_autoresume(struct snd_usb_audio *chip);
2625
void snd_usb_autosuspend(struct snd_usb_audio *chip);
27-
#else
28-
static inline int snd_usb_autoresume(struct snd_usb_audio *chip)
29-
{
30-
return 0;
31-
}
32-
static inline void snd_usb_autosuspend(struct snd_usb_audio *chip)
33-
{
34-
}
35-
#endif
3626

3727
#endif /* __USBAUDIO_POWER_H */

0 commit comments

Comments
 (0)