Skip to content

Commit 8a220d1

Browse files
zenghongling0719brauner
authored andcommitted
cachefiles: Fix error return when vfs_mkdir() fails
When vfs_mkdir() fails, the error code is not extracted from the returned error pointer. This causes mkdir_error to be reached with ret=0, which leads to returning ERR_PTR(0) (NULL) instead of a proper error pointer. Fix this by extracting the error code from the error pointer when vfs_mkdir() fails. Fixes: 406fad7 ("cachefiles: Fix oops in vfs_mkdir from cachefiles_get_directory") Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn> Link: https://patch.msgid.link/20260513103406.202320-1-zenghongling@kylinos.cn Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 4520592 commit 8a220d1

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

fs/cachefiles/namei.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ struct dentry *cachefiles_get_directory(struct cachefiles_cache *cache,
130130
ret = cachefiles_inject_write_error();
131131
if (ret == 0) {
132132
subdir = vfs_mkdir(&nop_mnt_idmap, d_inode(dir), subdir, 0700, NULL);
133+
if (IS_ERR(subdir))
134+
ret = PTR_ERR(subdir);
133135
} else {
134136
end_creating(subdir);
135137
subdir = ERR_PTR(ret);

0 commit comments

Comments
 (0)