Skip to content

Commit 8a6430a

Browse files
jwrdegoedeaxboe
authored andcommitted
libata: add ATA_HORKAGE_NO_NCQ_TRIM for Samsung 860 and 870 SSDs
Commit ca6bfcb ("libata: Enable queued TRIM for Samsung SSD 860") limited the existing ATA_HORKAGE_NO_NCQ_TRIM quirk from "Samsung SSD 8*", covering all Samsung 800 series SSDs, to only apply to "Samsung SSD 840*" and "Samsung SSD 850*" series based on information from Samsung. But there is a large number of users which is still reporting issues with the Samsung 860 and 870 SSDs combined with Intel, ASmedia or Marvell SATA controllers and all reporters also report these problems going away when disabling queued trims. Note that with AMD SATA controllers users are reporting even worse issues and only completely disabling NCQ helps there, this will be addressed in a separate patch. Fixes: ca6bfcb ("libata: Enable queued TRIM for Samsung SSD 860") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=203475 Cc: stable@vger.kernel.org Cc: Kate Hsuan <hpa@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Link: https://lore.kernel.org/r/20210823095220.30157-1-hdegoede@redhat.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent a9c9a6f commit 8a6430a

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/ata/libata-core.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3970,6 +3970,10 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
39703970
ATA_HORKAGE_ZERO_AFTER_TRIM, },
39713971
{ "Samsung SSD 850*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
39723972
ATA_HORKAGE_ZERO_AFTER_TRIM, },
3973+
{ "Samsung SSD 860*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
3974+
ATA_HORKAGE_ZERO_AFTER_TRIM, },
3975+
{ "Samsung SSD 870*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
3976+
ATA_HORKAGE_ZERO_AFTER_TRIM, },
39733977
{ "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
39743978
ATA_HORKAGE_ZERO_AFTER_TRIM, },
39753979

0 commit comments

Comments
 (0)