Skip to content

Commit 8a724d5

Browse files
committed
Suspend related fixes on Tegra
Merge series from Sameer Pujar <spujar@nvidia.com>: This series addresses following problems: * The runtime PM is not balanced in MVC driver, whenever mute or volume mixer controls are set. * Some of the AHUB devices (SFC, MVC, Mixer, AMX and ADX) use late system sleep. Suspend failure is seen on Jetson TX2 platform.
2 parents 750dc2f + cf36de4 commit 8a724d5

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

sound/soc/tegra/tegra210_adx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -514,8 +514,8 @@ static int tegra210_adx_platform_remove(struct platform_device *pdev)
514514
static const struct dev_pm_ops tegra210_adx_pm_ops = {
515515
SET_RUNTIME_PM_OPS(tegra210_adx_runtime_suspend,
516516
tegra210_adx_runtime_resume, NULL)
517-
SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
518-
pm_runtime_force_resume)
517+
SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
518+
pm_runtime_force_resume)
519519
};
520520

521521
static struct platform_driver tegra210_adx_driver = {

sound/soc/tegra/tegra210_amx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -583,8 +583,8 @@ static int tegra210_amx_platform_remove(struct platform_device *pdev)
583583
static const struct dev_pm_ops tegra210_amx_pm_ops = {
584584
SET_RUNTIME_PM_OPS(tegra210_amx_runtime_suspend,
585585
tegra210_amx_runtime_resume, NULL)
586-
SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
587-
pm_runtime_force_resume)
586+
SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
587+
pm_runtime_force_resume)
588588
};
589589

590590
static struct platform_driver tegra210_amx_driver = {

sound/soc/tegra/tegra210_mixer.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -666,8 +666,8 @@ static int tegra210_mixer_platform_remove(struct platform_device *pdev)
666666
static const struct dev_pm_ops tegra210_mixer_pm_ops = {
667667
SET_RUNTIME_PM_OPS(tegra210_mixer_runtime_suspend,
668668
tegra210_mixer_runtime_resume, NULL)
669-
SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
670-
pm_runtime_force_resume)
669+
SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
670+
pm_runtime_force_resume)
671671
};
672672

673673
static struct platform_driver tegra210_mixer_driver = {

sound/soc/tegra/tegra210_mvc.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ static int tegra210_mvc_put_mute(struct snd_kcontrol *kcontrol,
164164
if (err < 0)
165165
goto end;
166166

167-
return 1;
167+
err = 1;
168168

169169
end:
170170
pm_runtime_put(cmpnt->dev);
@@ -236,7 +236,7 @@ static int tegra210_mvc_put_vol(struct snd_kcontrol *kcontrol,
236236
TEGRA210_MVC_VOLUME_SWITCH_MASK,
237237
TEGRA210_MVC_VOLUME_SWITCH_TRIGGER);
238238

239-
return 1;
239+
err = 1;
240240

241241
end:
242242
pm_runtime_put(cmpnt->dev);
@@ -639,8 +639,8 @@ static int tegra210_mvc_platform_remove(struct platform_device *pdev)
639639
static const struct dev_pm_ops tegra210_mvc_pm_ops = {
640640
SET_RUNTIME_PM_OPS(tegra210_mvc_runtime_suspend,
641641
tegra210_mvc_runtime_resume, NULL)
642-
SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
643-
pm_runtime_force_resume)
642+
SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
643+
pm_runtime_force_resume)
644644
};
645645

646646
static struct platform_driver tegra210_mvc_driver = {

sound/soc/tegra/tegra210_sfc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3594,8 +3594,8 @@ static int tegra210_sfc_platform_remove(struct platform_device *pdev)
35943594
static const struct dev_pm_ops tegra210_sfc_pm_ops = {
35953595
SET_RUNTIME_PM_OPS(tegra210_sfc_runtime_suspend,
35963596
tegra210_sfc_runtime_resume, NULL)
3597-
SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
3598-
pm_runtime_force_resume)
3597+
SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
3598+
pm_runtime_force_resume)
35993599
};
36003600

36013601
static struct platform_driver tegra210_sfc_driver = {

0 commit comments

Comments
 (0)