Skip to content

Commit 8cf5dd2

Browse files
Prasanna Kumar T S Mbp3tk0v
authored andcommitted
EDAC/versalnet: Fix device name memory leak
The device name allocated via kzalloc() in init_one_mc() is assigned to dev->init_name but never freed on the normal removal path. device_register() copies init_name and then sets dev->init_name to NULL, so the name pointer becomes unreachable from the device. Thus leaking memory. Use a stack-local char array instead of using kzalloc() for name. Fixes: d5fe2fe ("EDAC: Add a driver for the AMD Versal NET DDR controller") Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260401111856.2342975-1-ptsm@linux.microsoft.com
1 parent 7fd2df2 commit 8cf5dd2

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

drivers/edac/versalnet_edac.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -777,9 +777,9 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i
777777
u32 num_chans, rank, dwidth, config;
778778
struct edac_mc_layer layers[2];
779779
struct mem_ctl_info *mci;
780+
char name[MC_NAME_LEN];
780781
struct device *dev;
781782
enum dev_type dt;
782-
char *name;
783783
int rc;
784784

785785
config = priv->adec[CONF + i * ADEC_NUM];
@@ -813,13 +813,9 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i
813813
layers[1].is_virt_csrow = false;
814814

815815
rc = -ENOMEM;
816-
name = kzalloc(MC_NAME_LEN, GFP_KERNEL);
817-
if (!name)
818-
return rc;
819-
820816
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
821817
if (!dev)
822-
goto err_name_free;
818+
return rc;
823819

824820
mci = edac_mc_alloc(i, ARRAY_SIZE(layers), layers, sizeof(struct mc_priv));
825821
if (!mci) {
@@ -858,8 +854,6 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i
858854
edac_mc_free(mci);
859855
err_dev_free:
860856
kfree(dev);
861-
err_name_free:
862-
kfree(name);
863857

864858
return rc;
865859
}

0 commit comments

Comments
 (0)