Skip to content

Commit 91840be

Browse files
mrpreThomas Gleixner
authored andcommitted
irq_work: Fix use-after-free in irq_work_single() on PREEMPT_RT
On PREEMPT_RT, non-HARD irq_work runs in per-CPU kthreads via run_irq_workd(), so irq_work_sync() uses rcuwait() to wait for BUSY==0. After irq_work_single() clears BUSY via atomic_cmpxchg(), it still dereferences @work for irq_work_is_hard() and rcuwait_wake_up(). An irq_work_sync() caller on another CPU that enters after BUSY is cleared can observe BUSY==0 immediately, return, and free the work before those accesses complete — causing a use-after-free. Fix this by wrapping run_irq_workd() in guard(rcu)() so that the entire irq_work_single() execution is within an RCU read-side critical section. Then add synchronize_rcu() in irq_work_sync() after rcuwait_wait_event() to ensure the caller waits for the RCU grace period before returning, preventing premature frees. Fixes: 8109796 ("irq_work: Allow irq_work_sync() to sleep if irq_work() no IRQ support.") Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Suggested-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Link: https://patch.msgid.link/20260330073234.303732-1-jiayuan.chen@linux.dev
1 parent cefafbd commit 91840be

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

kernel/irq_work.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,12 @@ void irq_work_sync(struct irq_work *work)
292292
!arch_irq_work_has_interrupt()) {
293293
rcuwait_wait_event(&work->irqwait, !irq_work_is_busy(work),
294294
TASK_UNINTERRUPTIBLE);
295+
/*
296+
* Ensure irq_work_single() does not access @work
297+
* after removing IRQ_WORK_BUSY. It is always
298+
* accessed within a RCU-read section.
299+
*/
300+
synchronize_rcu();
295301
return;
296302
}
297303

@@ -302,6 +308,7 @@ EXPORT_SYMBOL_GPL(irq_work_sync);
302308

303309
static void run_irq_workd(unsigned int cpu)
304310
{
311+
guard(rcu)();
305312
irq_work_run_list(this_cpu_ptr(&lazy_list));
306313
}
307314

0 commit comments

Comments
 (0)