Skip to content

Commit 922952f

Browse files
rafaeljwij-intel
authored andcommitted
platform/x86: intel/smartconnect: Check ACPI_HANDLE() against NULL
Every platform driver can be forced to match a device that doesn't match its list of device IDs because of device_match_driver_override(), so platform drivers that rely on the existence of a device's ACPI companion object need to verify its presence. Accordingly, add a requisite ACPI_HANDLE() check against NULL to the platform/x86 intel/smartconnect driver. Fixes: 8a44bd3 ("platform/x86: intel/smartconnect: Convert ACPI driver to a platform one") Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://patch.msgid.link/7956676.EvYhyI6sBW@rafael.j.wysocki Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent 51e91ad commit 922952f

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

drivers/platform/x86/intel/smartconnect.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,14 @@ MODULE_LICENSE("GPL");
1212

1313
static int smartconnect_acpi_probe(struct platform_device *pdev)
1414
{
15-
acpi_handle handle = ACPI_HANDLE(&pdev->dev);
1615
unsigned long long value;
16+
acpi_handle handle;
1717
acpi_status status;
1818

19+
handle = ACPI_HANDLE(&pdev->dev);
20+
if (!handle)
21+
return -ENODEV;
22+
1923
status = acpi_evaluate_integer(handle, "GAOS", NULL, &value);
2024
if (ACPI_FAILURE(status))
2125
return -EINVAL;

0 commit comments

Comments
 (0)