Skip to content

Commit 9985d53

Browse files
author
Sudeep Holla
committed
firmware: arm_ffa: Fix per-vcpu self notifications handling in workqueue
Per-vcpu notification handling already runs from a per-cpu work item on the target cpu. Routing that path back through smp_call_function_single() re-enters the call-function IPI path and executes the notification handler with interrupts disabled. That makes the framework path unsafe, since it takes a mutex, allocates memory with GFP_KERNEL, and invokes client callbacks. Handle per-vcpu self notifications directly from the existing per-cpu work item instead. This keeps the per-vcpu path in task context and avoids the extra IPI hop entirely. Fixes: 3a3e2b8 ("firmware: arm_ffa: Avoid queuing work when running on the worker queue") Link: https://patch.msgid.link/20260428-ffa_fixes-v2-4-8595ae450034@kernel.org Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
1 parent 9b5597a commit 9985d53

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/firmware/arm_ffa/driver.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1543,7 +1543,7 @@ static void notif_pcpu_irq_work_fn(struct work_struct *work)
15431543
notif_pcpu_work);
15441544
struct ffa_drv_info *info = pcpu->info;
15451545

1546-
ffa_self_notif_handle(smp_processor_id(), true, info);
1546+
notif_get_and_handle(info);
15471547
}
15481548

15491549
static const struct ffa_info_ops ffa_drv_info_ops = {

0 commit comments

Comments
 (0)