Skip to content

Commit a40c0e8

Browse files
yungFundamentalhdeller
authored andcommitted
fbdev: clps711x-fb: Request memory region for MMIO
Use devm_platform_get_and_ioremap_resource() for resource 0 (the MMIO control register range) instead of open-coding platform_get_resource() and devm_ioremap() separately. The helper requests the memory region before mapping it, which registers the range in /proc/iomem and prevents another driver from mapping the same registers. This makes resource 0 consistent with resource 1 (the framebuffer), which already uses devm_platform_get_and_ioremap_resource(). Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Amit Barzilai <amit.barzilai22@gmail.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent d2386d9 commit a40c0e8

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

drivers/video/fbdev/clps711x-fb.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -216,12 +216,9 @@ static int clps711x_fb_probe(struct platform_device *pdev)
216216
cfb = info->par;
217217
platform_set_drvdata(pdev, info);
218218

219-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
220-
if (!res)
221-
goto out_fb_release;
222-
cfb->base = devm_ioremap(dev, res->start, resource_size(res));
223-
if (!cfb->base) {
224-
ret = -ENOMEM;
219+
cfb->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
220+
if (IS_ERR(cfb->base)) {
221+
ret = PTR_ERR(cfb->base);
225222
goto out_fb_release;
226223
}
227224

0 commit comments

Comments
 (0)