Skip to content

Commit a5bd108

Browse files
rfvirgilbroonie
authored andcommitted
firmware: cs_dsp: Avoid using a u32 as a __be32 in cs_dsp_mock_mem_maps.c
In cs_dsp_mock_xm_header_drop_from_regmap_cache() for the ADSP2 case read the big-endian firmware word into a dedicated __be32 variable instead of using the same u32 for both the big-endian and cpu-endian value. Fixes: 41e78c0 ("firmware: cs_dsp: Add mock DSP memory map for KUnit testing") Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://patch.msgid.link/20241217113127.186736-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 8bfb66c commit a5bd108

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

drivers/firmware/cirrus/test/cs_dsp_mock_mem_maps.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,8 @@ void cs_dsp_mock_xm_header_drop_from_regmap_cache(struct cs_dsp_test *priv)
526526
{
527527
unsigned int xm = cs_dsp_mock_base_addr_for_mem(priv, WMFW_ADSP2_XM);
528528
unsigned int bytes;
529-
u32 num_algs;
529+
__be32 num_algs_be32;
530+
unsigned int num_algs;
530531

531532
switch (priv->dsp->type) {
532533
case WMFW_ADSP2:
@@ -536,8 +537,8 @@ void cs_dsp_mock_xm_header_drop_from_regmap_cache(struct cs_dsp_test *priv)
536537
*/
537538
regmap_raw_read(priv->dsp->regmap,
538539
xm + (offsetof(struct wmfw_adsp2_id_hdr, n_algs) / 2),
539-
&num_algs, sizeof(num_algs));
540-
num_algs = be32_to_cpu(num_algs);
540+
&num_algs_be32, sizeof(num_algs_be32));
541+
num_algs = be32_to_cpu(num_algs_be32);
541542
bytes = sizeof(struct wmfw_adsp2_id_hdr) +
542543
(num_algs * sizeof(struct wmfw_adsp2_alg_hdr)) +
543544
4 /* terminator word */;

0 commit comments

Comments
 (0)