Skip to content

Commit afaa0a4

Browse files
committed
Merge tag 'edac_urgent_for_v7.1_rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras
Pull EDAC fix from Borislav Petkov: - Fix a string leak in the versalnet driver * tag 'edac_urgent_for_v7.1_rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras: EDAC/versalnet: Fix device name memory leak
2 parents aa54b1d + 8cf5dd2 commit afaa0a4

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

drivers/edac/versalnet_edac.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -777,9 +777,9 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i
777777
u32 num_chans, rank, dwidth, config;
778778
struct edac_mc_layer layers[2];
779779
struct mem_ctl_info *mci;
780+
char name[MC_NAME_LEN];
780781
struct device *dev;
781782
enum dev_type dt;
782-
char *name;
783783
int rc;
784784

785785
config = priv->adec[CONF + i * ADEC_NUM];
@@ -813,13 +813,9 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i
813813
layers[1].is_virt_csrow = false;
814814

815815
rc = -ENOMEM;
816-
name = kzalloc(MC_NAME_LEN, GFP_KERNEL);
817-
if (!name)
818-
return rc;
819-
820816
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
821817
if (!dev)
822-
goto err_name_free;
818+
return rc;
823819

824820
mci = edac_mc_alloc(i, ARRAY_SIZE(layers), layers, sizeof(struct mc_priv));
825821
if (!mci) {
@@ -858,8 +854,6 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i
858854
edac_mc_free(mci);
859855
err_dev_free:
860856
kfree(dev);
861-
err_name_free:
862-
kfree(name);
863857

864858
return rc;
865859
}

0 commit comments

Comments
 (0)