Skip to content

Commit b1b4efe

Browse files
andy-shevgregkh
authored andcommitted
serial: 8250_mid: Disable DMA for selected platforms
In accordance with Errata (specification updates) HSUART May Stop Functioning when DMA is Active. - Denverton document #572409, rev 3.4, DNV60 - Ice Lake Xeon D document #714070, ICXD65 - Snowridge document #731931, SNR44 For a quick fix just disable the respective callbacks during the device probe. Depending on the future development we might remove them completely. Reported-by: micas-opensource <zjianan156@gmail.com> Closes: https://lore.kernel.org/linux-serial/20250625031409.2404219-1-opensource@ruijie.com.cn/ Fixes: 6ede6dc ("serial: 8250_mid: add support for DMA engine handling from UART MMIO") Cc: stable <stable@kernel.org> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://patch.msgid.link/20260626094937.561776-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 061b627 commit b1b4efe

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

drivers/tty/serial/8250/8250_mid.c

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <linux/module.h>
1111
#include <linux/pci.h>
1212
#include <linux/rational.h>
13+
#include <linux/util_macros.h>
1314

1415
#include <linux/dma/hsu.h>
1516

@@ -368,8 +369,16 @@ static const struct mid8250_board dnv_board = {
368369
.freq = 133333333,
369370
.base_baud = 115200,
370371
.bar = 1,
371-
.setup = dnv_setup,
372-
.exit = dnv_exit,
372+
/*
373+
* Errata:
374+
* HSUART May Stop Functioning when DMA is Active.
375+
*
376+
* - Denverton document #572409, rev 3.4, DNV60
377+
* - Ice Lake Xeon D document #714070, ICXD65
378+
* - Snowridge document #731931, SNR44
379+
*/
380+
.setup = PTR_IF(false, dnv_setup),
381+
.exit = PTR_IF(false, dnv_exit),
373382
};
374383

375384
static const struct pci_device_id pci_ids[] = {

0 commit comments

Comments
 (0)