Skip to content

Commit bf237a9

Browse files
Yongxing Mouvinodkoul
authored andcommitted
phy: qcom: edp: Fix AUX_CFG8 programming for DP mode
AUX_CFG8 depends on whether the PHY is operating in eDP or DP mode, not the selected swing/pre-emphasis table. All supported platforms already have the proper tables, so remove the unnecessary check. Cc: stable@vger.kernel.org Fixes: 6078b8c ("phy: qcom: edp: Add set_mode op for configuring eDP/DP submode") Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> Link: https://patch.msgid.link/20260427-edp_phy-v5-4-3bb876824475@oss.qualcomm.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 3d22594 commit bf237a9

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

drivers/phy/qualcomm/phy-qcom-edp.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -325,12 +325,7 @@ static int qcom_edp_phy_init(struct phy *phy)
325325
DP_PHY_PD_CTL_PLL_PWRDN | DP_PHY_PD_CTL_DP_CLAMP_EN,
326326
edp->edp + DP_PHY_PD_CTL);
327327

328-
/*
329-
* TODO: Re-work the conditions around setting the cfg8 value
330-
* when more information becomes available about why this is
331-
* even needed.
332-
*/
333-
if (edp->cfg->dp_swing_pre_emph_cfg && !edp->is_edp)
328+
if (!edp->is_edp)
334329
aux_cfg[8] = 0xb7;
335330

336331
writel(0xfc, edp->edp + DP_PHY_MODE);

0 commit comments

Comments
 (0)