Skip to content

Commit cba53fe

Browse files
jhovoldbroonie
authored andcommitted
spi: cadence-quadspi: fix clock imbalance on probe failure
Drop the bogus runtime PM get on probe failures that was never needed and that leaks a usage count reference while preventing the clocks from being disabled (as runtime PM has not yet been enabled). Fixes: 1889dd2 ("spi: cadence-quadspi: Fix clock disable on probe failure path") Cc: stable@vger.kernel.org # 6.19 Cc: Anurag Dutta <a-dutta@ti.com> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://patch.msgid.link/20260421125354.1534871-3-johan@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 5ff4d5d commit cba53fe

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/spi/spi-cadence-quadspi.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2000,8 +2000,7 @@ static int cqspi_probe(struct platform_device *pdev)
20002000
pm_runtime_disable(dev);
20012001
cqspi_controller_enable(cqspi, 0);
20022002
disable_clks:
2003-
if (pm_runtime_get_sync(&pdev->dev) >= 0)
2004-
clk_bulk_disable_unprepare(CLK_QSPI_NUM, cqspi->clks);
2003+
clk_bulk_disable_unprepare(CLK_QSPI_NUM, cqspi->clks);
20052004

20062005
return ret;
20072006
}

0 commit comments

Comments
 (0)