Skip to content

Commit cd8d29c

Browse files
committed
ntfs: fix uninitialized variables in ntfs_ea_set_wsl_inode()
Smatch reported uninitialized symbol warnings in ntfs_ea_set_wsl_inode() and __ntfs_create(). In ntfs_ea_set_wsl_inode(), the err variable could be returned without initialization if no flags are set and rdev is zero. Additionally, ea_size might remain uninitialized from the caller's perspective if no EA operations are performed. While these cases might not be triggered under current logic, we initialize them to zero to satisfy the static checker. Reported-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
1 parent 545834a commit cd8d29c

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

fs/ntfs/ea.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,10 @@ int ntfs_ea_set_wsl_inode(struct inode *inode, dev_t rdev, __le16 *ea_size,
406406
unsigned int flags)
407407
{
408408
__le32 v;
409-
int err;
409+
int err = 0;
410+
411+
if (ea_size)
412+
*ea_size = 0;
410413

411414
if (flags & NTFS_EA_UID) {
412415
/* Store uid to lxuid EA */

0 commit comments

Comments
 (0)