KVM: s390: vsie: Fix memory leak when unshadowing

Claudio Imbrenda · Claudio Imbrenda · commit d0f2eb4493d1 · 2026-05-22T11:25:10.000+02:00
When performing a partial unshadowing, the rmap was being leaked. Add the missing kfree(). Fixes: a2c17f9 ("KVM: s390: New gmap code") Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com> Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com> Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
diff --git a/arch/s390/kvm/gmap.c b/arch/s390/kvm/gmap.c
@@ -1143,8 +1143,10 @@ void _gmap_handle_vsie_unshadow_event(struct gmap *parent, gfn_t gfn)
 		}
 		scoped_guard(spinlock, &sg->host_to_rmap_lock)
 			head = radix_tree_delete(&sg->host_to_rmap, gfn);
-		gmap_for_each_rmap_safe(rmap, rnext, head)
+		gmap_for_each_rmap_safe(rmap, rnext, head) {
 			gmap_unshadow_level(sg, rmap->r_gfn, rmap->level);
+			kfree(rmap);
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1143,8 +1143,10 @@ void _gmap_handle_vsie_unshadow_event(struct gmap *parent, gfn_t gfn)`
`1143`	`1143`	`}`
`1144`	`1144`	`scoped_guard(spinlock, &sg->host_to_rmap_lock)`
`1145`	`1145`	`head = radix_tree_delete(&sg->host_to_rmap, gfn);`
`1146`		`- gmap_for_each_rmap_safe(rmap, rnext, head)`
	`1146`	`+ gmap_for_each_rmap_safe(rmap, rnext, head) {`
`1147`	`1147`	`gmap_unshadow_level(sg, rmap->r_gfn, rmap->level);`
	`1148`	`+ kfree(rmap);`
	`1149`	`+ }`
`1148`	`1150`	`}`
`1149`	`1151`	`}`
`1150`	`1152`