Skip to content

Commit d2386d9

Browse files
yungFundamentalhdeller
authored andcommitted
fbdev: cobalt_lcdfb: Request memory region
Use devm_platform_get_and_ioremap_resource() instead of open-coding platform_get_resource() and devm_ioremap() separately. The helper requests the memory region before mapping it, which registers the range in /proc/iomem and prevents another driver from mapping the same registers. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Amit Barzilai <amit.barzilai22@gmail.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent b1aaf11 commit d2386d9

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

drivers/video/fbdev/cobalt_lcdfb.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -295,19 +295,13 @@ static int cobalt_lcdfb_probe(struct platform_device *dev)
295295
if (!info)
296296
return -ENOMEM;
297297

298-
res = platform_get_resource(dev, IORESOURCE_MEM, 0);
299-
if (!res) {
298+
info->screen_base = devm_platform_get_and_ioremap_resource(dev, 0, &res);
299+
if (IS_ERR(info->screen_base)) {
300300
framebuffer_release(info);
301-
return -EBUSY;
301+
return PTR_ERR(info->screen_base);
302302
}
303303

304304
info->screen_size = resource_size(res);
305-
info->screen_base = devm_ioremap(&dev->dev, res->start,
306-
info->screen_size);
307-
if (!info->screen_base) {
308-
framebuffer_release(info);
309-
return -ENOMEM;
310-
}
311305

312306
info->fbops = &cobalt_lcd_fbops;
313307
info->fix = cobalt_lcdfb_fix;

0 commit comments

Comments
 (0)