Skip to content

Commit daff723

Browse files
adam900710axboe
authored andcommitted
block: do not warn when doing greedy allocation in folio_alloc_greedy()
During one of my local btrfs fstests runs, folio_alloc() inside folio_alloc_greedy() triggered an allocation failure report when trying to allocate an order-4 folio. The kernel is from the latest development branch, which is utilizing the IOMAP_DIO_BOUNCE flag for direct writes when the inode requires checksum. Unfortunately I didn't save the full log, only the function and the order. When the IOMAP_DIO_BOUNCE flag is utilized, we will hit the following call chain: bio_iov_iter_bounce_write() |- folio_alloc_greedy() |- folio_alloc(gfp | __GFP_NORETRY, get_order(*size)); However __GFP_NORETRY will still emit an allocation failure report when it fails. And folio_alloc_greedy() will retry with a smaller order anyway, there is no point in emitting that allocation failure report. Append the __GFP_NOWARN flag to folio_alloc() for the larger-order folio attempts. Fixes: 8dd5e7c ("block: add helpers to bounce buffer an iov_iter into bios") Signed-off-by: Qu Wenruo <wqu@suse.com> Link: https://patch.msgid.link/d10571445ee505d95ba6eaad7558fc1f556d2921.1784020005.git.wqu@suse.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent d35e236 commit daff723

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

block/bio.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1285,7 +1285,8 @@ static struct folio *folio_alloc_greedy(gfp_t gfp, size_t *size,
12851285
struct folio *folio;
12861286

12871287
while (*size > minsize) {
1288-
folio = folio_alloc(gfp | __GFP_NORETRY, get_order(*size));
1288+
folio = folio_alloc(gfp | __GFP_NORETRY | __GFP_NOWARN,
1289+
get_order(*size));
12891290
if (folio)
12901291
return folio;
12911292
*size = rounddown_pow_of_two(*size - 1);

0 commit comments

Comments
 (0)