ntb: ntb_pingpong: remove redundant initialization of variables msg_data and spad_data

Colin Ian King · jonmason · commit e631548027ca · 2021-09-05T18:04:46.000-04:00
The variables msg_data and spad_data are being initialized with values
that are never read, they are being updated later on. The initializations
are redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Acked-by: Serge Semin &lt;fancer.lancer@gmail.com&gt;
Signed-off-by: Jon Mason &lt;jdmason@kudzu.us&gt;
diff --git a/drivers/ntb/test/ntb_pingpong.c b/drivers/ntb/test/ntb_pingpong.c
@@ -187,7 +187,7 @@ static void pp_ping(struct pp_ctx *pp)
 
 static void pp_pong(struct pp_ctx *pp)
 {
-	u32 msg_data = -1, spad_data = -1;
+	u32 msg_data, spad_data;
 	int pidx = 0;
 
 	/* Read pong data */

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ static void pp_ping(struct pp_ctx *pp)`
`187`	`187`
`188`	`188`	`static void pp_pong(struct pp_ctx *pp)`
`189`	`189`	`{`
`190`		`- u32 msg_data = -1, spad_data = -1;`
	`190`	`+ u32 msg_data, spad_data;`
`191`	`191`	`int pidx = 0;`
`192`	`192`
`193`	`193`	`/* Read pong data */`