Skip to content

Commit e8a44ae

Browse files
Sean ChangTrond Myklebust
authored andcommitted
NFS: remove redundant __private attribute from nfs_page_class
The nfs_page_class tracepoint uses a pointer for the 'req' field marked with the __private attribute. This causes Sparse to complain about dereferencing a private pointer within the trace ring buffer context, specifically during the TP_fast_assign() operation. This fixes a Sparse warning introduced in commit b6ef079 ("nfs: more in-depth tracing of writepage events") by removing the redundant __private attribute from the 'req' field. Reviewed-by: Benjamin Coddington <bcodding@hammerspace.com> Signed-off-by: Sean Chang <seanwascoding@gmail.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent 6e7daa3 commit e8a44ae

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/nfs/nfstrace.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1496,7 +1496,7 @@ DECLARE_EVENT_CLASS(nfs_page_class,
14961496
__field(dev_t, dev)
14971497
__field(u32, fhandle)
14981498
__field(u64, fileid)
1499-
__field(const struct nfs_page *__private, req)
1499+
__field(const struct nfs_page *, req)
15001500
__field(loff_t, offset)
15011501
__field(unsigned int, count)
15021502
__field(unsigned long, flags)

0 commit comments

Comments
 (0)