Skip to content

Commit ebeef57

Browse files
krzkbroonie
authored andcommitted
spi: dt-bindings: fsl: Correct GPIO flags in the example
IRQ_TYPE_xxx flags are not correct in the context of GPIO flags. These are simple defines so they could be used in DTS but they will not have the same meaning: IRQ_TYPE_EDGE_RISING = 1 = GPIO_ACTIVE_LOW. Correct the example DTS to use proper flags for chip select GPIOs, assuming the author of the code wanted similar logical behavior: IRQ_TYPE_EDGE_RISING => GPIO_ACTIVE_HIGH Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Link: https://patch.msgid.link/20260413085947.51047-2-krzysztof.kozlowski@oss.qualcomm.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent c4c3fc8 commit ebeef57

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

Documentation/devicetree/bindings/spi/fsl,spi.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,16 @@ unevaluatedProperties: false
5959

6060
examples:
6161
- |
62-
#include <dt-bindings/interrupt-controller/irq.h>
62+
#include <dt-bindings/gpio/gpio.h>
6363
6464
spi@4c0 {
6565
compatible = "fsl,spi";
6666
reg = <0x4c0 0x40>;
6767
cell-index = <0>;
6868
interrupts = <82 0>;
6969
mode = "cpu";
70-
cs-gpios = <&gpio 18 IRQ_TYPE_EDGE_RISING // device reg=<0>
71-
&gpio 19 IRQ_TYPE_EDGE_RISING>; // device reg=<1>
70+
cs-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>, // device reg=<0>
71+
<&gpio 19 GPIO_ACTIVE_HIGH>; // device reg=<1>
7272
};
7373
7474
...

0 commit comments

Comments
 (0)