Skip to content

Commit ee37bc7

Browse files
rfvirgilbroonie
authored andcommitted
firmware: cs_dsp: Delete redundant assignments in cs_dsp_test_bin.c
Delete two redundant assignments in cs_dsp_test_bin.c. Unfortunately none of W=1 or the static analysis tools I ran flagged these. Fixes: dd0b6b1 ("firmware: cs_dsp: Add KUnit testing of bin file download") Reported-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com> Closes: https://scan7.scan.coverity.com/#/project-view/52337/11354?selectedIssue=1602511 Closes: https://scan7.scan.coverity.com/#/project-view/52337/11354?selectedIssue=1602490 Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://patch.msgid.link/20241219155719.84276-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent cf12626 commit ee37bc7

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

drivers/firmware/cirrus/test/cs_dsp_test_bin.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -500,9 +500,6 @@ static void bin_patch_one_word_multiple_algs(struct kunit *test)
500500

501501
/* Add one payload per algorithm */
502502
for (i = 0; i < ARRAY_SIZE(bin_test_mock_algs); ++i) {
503-
alg_base_words = cs_dsp_mock_xm_header_get_alg_base_in_words(priv,
504-
bin_test_mock_algs[i].id,
505-
param->mem_type);
506503
reg_inc_per_word = cs_dsp_mock_reg_addr_inc_per_unpacked_word(priv);
507504

508505
cs_dsp_mock_bin_add_patch(priv->local->bin_builder,
@@ -566,9 +563,6 @@ static void bin_patch_one_word_multiple_algs_unordered(struct kunit *test)
566563
/* Add one payload per algorithm */
567564
for (i = 0; i < ARRAY_SIZE(bin_test_mock_algs); ++i) {
568565
alg_idx = alg_order[i];
569-
alg_base_words = cs_dsp_mock_xm_header_get_alg_base_in_words(priv,
570-
bin_test_mock_algs[alg_idx].id,
571-
param->mem_type);
572566
reg_inc_per_word = cs_dsp_mock_reg_addr_inc_per_unpacked_word(priv);
573567

574568
cs_dsp_mock_bin_add_patch(priv->local->bin_builder,

0 commit comments

Comments
 (0)