Skip to content

[RFC] some patches updated during SDCA library testing #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shumingfan wants to merge 5 commits into from
Closed

[RFC] some patches updated during SDCA library testing #5469

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4b9a84
ASoC: SDCA: correct the calculation of the maximum init table size
shumingfan Jun 27, 2025
5e24db0
ASoC: SDCA: move the reading mipi-sdca-control-cn-list property to th…
shumingfan Jun 27, 2025
84bf2e8
ASoC: SDCA: certain entities have mipi-sdca-input-pin-list property
shumingfan Jun 27, 2025
8e5a534
ASoC: SDCA: add put/get callback for Q7.8 volume format
shumingfan Jun 30, 2025
0857185
ASoC: SDCA: add route by the number of input pins in MU entity
shumingfan Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sound/soc/sdca/sdca_functions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1634,7 +1634,14 @@ static int find_sdca_entity_connection(struct device *dev,
ret = fwnode_property_read_u64(entity_node, "mipi-sdca-input-pin-list", &pin_list);
if (ret == -EINVAL) {
/* Allow missing pin lists, assume no pins. */
dev_warn(dev, "%s: missing pin list\n", entity->label);
if (strstr(entity->label, "OT") || strstr(entity->label, "MU") ||
strstr(entity->label, "SU") || strstr(entity->label, "FU") ||
strstr(entity->label, "XU") || strstr(entity->label, "CX") ||
strstr(entity->label, "CRU") || strstr(entity->label, "UDMPU") ||
strstr(entity->label, "MFPU") || strstr(entity->label, "SMPU") ||
strstr(entity->label, "SAPU") || strstr(entity->label, "PPU") ||
strstr(entity->label, "SPE"))
dev_warn(dev, "%s: missing pin list\n", entity->label);

@charleskeepax charleskeepax Jul 7, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just upstreamed a patch this morning to just remove this warning it is probably a bit overly cautious and it seems overly complex to carefully mask the entities like this.

@charleskeepax charleskeepax Jul 7, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies and a link: https://lore.kernel.org/linux-sound/20250707124155.2596744-3-ckeepax@opensource.cirrus.com/T/#u

@shumingfan shumingfan Jul 8, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for the fix.

return 0;
} else if (ret) {
dev_err(dev, "%s: failed to read pin list: %d\n", entity->label, ret);
Expand Down