Skip to content

Revert "ASoC: Intel: sof_sdw: create SSP BT DAI if bt_link_mask sets"#5553

Merged
ujfalusi merged 1 commit into
thesofproject:topic/sof-devfrom
bardliao:revert-bt
Oct 8, 2025
Merged

Revert "ASoC: Intel: sof_sdw: create SSP BT DAI if bt_link_mask sets"#5553
ujfalusi merged 1 commit into
thesofproject:topic/sof-devfrom
bardliao:revert-bt

Conversation

@bardliao

@bardliao bardliao commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

This reverts commit af0aefc.

struct sof_intel_dsp_desc *chip is from sdev->pdata not snd_soc_card_get_drvdata(card).
const struct sof_intel_dsp_desc *chip = get_chip_info(snd_soc_card_get_drvdata(card)); will lead to kernel NULL pointer dereference

@ujfalusi

ujfalusi commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

@macchian, the reverted patch have few issues:
is a huge layer violation itself
and
this line was completely wrong:
const struct sof_intel_dsp_desc *chip = get_chip_info(snd_soc_card_get_drvdata(card));

snd_soc_card_get_drvdata(card) returns struct asoc_sdw_mc_private * (which starts with struct snd_soc_card)
struct snd_soc_card() needs struct snd_sof_pdata * (which starts with a name).

Have you tested the patch itself?

@ujfalusi ujfalusi merged commit 73ba76b into thesofproject:topic/sof-dev Oct 8, 2025
9 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants