check-kmod-load-unload-after-playback: disable logging in subtest

marc-hb · marc-hb · commit a7b9428065ff · 2024-04-20T11:07:27.000-07:00
This unblocks #1170 and allows "installing" the func_exit_handler() trap in start_test() which will allow making start_test() optional. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
diff --git a/test-case/check-kmod-load-unload-after-playback.sh b/test-case/check-kmod-load-unload-after-playback.sh
@@ -64,7 +64,10 @@ fi
 
 playback_subtest()
 {
-    "$case_dir"/check-playback.sh -l 1 -t $tplg -d $pb_duration ||
+    # Disable logging with -s because subtests don't invoke func_exit_handler() which
+    # can leave loggers behind (and hang rmmod)
+    # Also, we don't want two (concurrent!?) sets of logs for the same test.
+    "$case_dir"/check-playback.sh -l 1 -t $tplg -d $pb_duration -s ||
     die "aplay check failed"
 }
 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,10 @@ fi`
`64`	`64`
`65`	`65`	`playback_subtest()`
`66`	`66`	`{`
`67`		`- "$case_dir"/check-playback.sh -l 1 -t $tplg -d $pb_duration \|\|`
	`67`	`+ # Disable logging with -s because subtests don't invoke func_exit_handler() which`
	`68`	`+ # can leave loggers behind (and hang rmmod)`
	`69`	`+ # Also, we don't want two (concurrent!?) sets of logs for the same test.`
	`70`	`+ "$case_dir"/check-playback.sh -l 1 -t $tplg -d $pb_duration -s \|\|`
`68`	`71`	`die "aplay check failed"`
`69`	`72`	`}`
`70`	`73`