volume: avoid use-after-free in init error path

On an invalid ramp type the init error path freed the component data
then read a field from it. Free the dependent allocation before the
component data and stop dereferencing it afterwards.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

Author: lrgirdwo

src/audio/volume/volume_ipc3.c

@@ -157,8 +157,11 @@ int volume_init(struct processing_module *mod)
 		break;
 	default:
 		comp_err(dev, "invalid ramp type %d", vol->ramp);
-		mod_free(mod, cd);
+		/* free cd->vol before cd: freeing cd first would leave the
+		 * following cd->vol read dereferencing freed memory
+		 */
 		mod_free(mod, cd->vol);
+		mod_free(mod, cd);
 		return -EINVAL;
 	}