Skip to content

Commit 3f7738d

Browse files
abonislawskikv2019i
authored andcommitted
audio: init align to avoid uninitialized read in error log
sof_dma_get_attribute() can return an error without writing its output parameter, so logging align on that path read an uninitialized value. Initialize align to 0 in the host/dai zephyr and legacy params paths. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
1 parent 1839efa commit 3f7738d

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/audio/dai-legacy.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ int dai_common_params(struct dai_data *dd, struct comp_dev *dev,
467467
uint32_t period_bytes;
468468
uint32_t buffer_size;
469469
uint32_t addr_align;
470-
uint32_t align;
470+
uint32_t align = 0;
471471
int err;
472472

473473
comp_dbg(dev, "dai_params()");

src/audio/dai-zephyr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -977,7 +977,7 @@ static int dai_set_dma_buffer(struct dai_data *dd, struct comp_dev *dev,
977977
uint32_t buffer_size;
978978
uint32_t buffer_size_preferred;
979979
uint32_t addr_align;
980-
uint32_t align;
980+
uint32_t align = 0;
981981
int err;
982982

983983
comp_dbg(dev, "entry");

src/audio/host-legacy.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,7 @@ int host_common_params(struct host_data *hd, struct comp_dev *dev,
686686
uint32_t period_bytes;
687687
uint32_t buffer_size;
688688
uint32_t addr_align;
689-
uint32_t align;
689+
uint32_t align = 0;
690690
int err;
691691

692692
/* host params always installed by pipeline IPC */

src/audio/host-zephyr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,7 @@ int host_common_params(struct host_data *hd, struct comp_dev *dev,
887887
uint32_t buffer_size;
888888
uint32_t buffer_size_preferred;
889889
uint32_t addr_align;
890-
uint32_t align;
890+
uint32_t align = 0;
891891
int i, err;
892892
bool is_scheduling_source = dev == dev->pipeline->sched_comp;
893893
uint32_t round_up_size;

0 commit comments

Comments
 (0)