Skip to content

Commit 56b508b

Browse files
committed
mux: ipc3: enforce mux_mix_check result
mux_set_values() logged a mux_mix_check() failure but still returned success, applying an invalid routing matrix. Return -EINVAL, matching the IPC4 path. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
1 parent 280d2c3 commit 56b508b

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

src/audio/mux/mux_ipc3.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,10 @@ static int mux_set_values(struct processing_module *mod)
7070
}
7171

7272
if (cd->comp_type == SOF_COMP_MUX) {
73-
if (mux_mix_check(cfg))
73+
if (mux_mix_check(cfg)) {
7474
comp_err(dev, "mux component is not able to mix channels");
75+
return -EINVAL;
76+
}
7577
}
7678

7779
for (i = 0; i < cfg->num_streams; i++) {

0 commit comments

Comments
 (0)