arch: string.h: use memset_s for all bzero uses.

Safer and fixes the following GCC11 warning

In file included from /home/lrg/work/sof/sof/src/include/sof/string.h:11,
                 from /home/lrg/work/sof/sof/src/include/sof/debug/debug.h:17,
                 from /home/lrg/work/sof/sof/src/platform/baytrail/platform.c:9:
/home/lrg/work/sof/sof/src/platform/baytrail/platform.c: In function 'platform_init':
/home/lrg/work/sof/sof/src/arch/xtensa/include/arch/string.h:22:9: error: 'memset' offset [0, 4095] is out of the bounds [0, 0] [-Werror=array-bounds]
   22 |         memset(ptr, 0, size)
      |         ^~~~~~~~~~~~~~~~~~~~
/home/lrg/work/sof/sof/src/include/sof/lib/alloc.h:160:9: note: in expansion of macro 'arch_bzero'
  160 |         arch_bzero(ptr, size)
      |         ^~~~~~~~~~
/home/lrg/work/sof/sof/src/platform/baytrail/platform.c:198:9: note: in expansion of macro 'bzero'
  198 |         bzero((void *)MAILBOX_BASE, MAILBOX_SIZE);
      |         ^~~~~

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

Author: lrgirdwo

src/arch/xtensa/include/arch/string.h

@@ -18,13 +18,8 @@
 #define arch_memcpy(dest, src, size) \
 	xthal_memcpy(dest, src, size)
 
-#if __XCC__ && !defined(UNIT_TEST)
 #define arch_bzero(ptr, size)	\
 	memset_s(ptr, size, 0, size)
-#else
-#define arch_bzero(ptr, size)	\
-	memset(ptr, 0, size)
-#endif
 
 void *xthal_memcpy(void *dst, const void *src, size_t len);
 

test/cmocka/src/common_mocks.c

@@ -90,6 +90,17 @@ int WEAK memcpy_s(void *dest, size_t dest_size,
 	return 0;
 }
 
+int WEAK memset_s(void *dest, size_t size1,
+		  int c, size_t size2)
+{
+	if (!dest)
+		return -EINVAL;
+
+	memset(dest, c, size1);
+
+	return 0;
+}
+
 int WEAK rstrlen(const char *s)
 {
 	return strlen(s);