module_adapter: make fragmented-transfer size per-instance

The reassembly size for fragmented runtime-params transfers was a
file-scope static shared by every component, so interleaved transfers to
different components corrupted each other's state. Move it into
per-instance module state.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

Author: lrgirdwo

src/audio/module_adapter/module_adapter_ipc3.c

@@ -184,21 +184,25 @@ static int module_adapter_get_set_params(struct comp_dev *dev, struct sof_ipc_ct
 	const struct module_interface *const interface = mod->dev->drv->adapter_ops;
 	enum module_cfg_fragment_position pos;
 	uint32_t data_offset_size;
-	static uint32_t size;
 
 	comp_dbg(dev, "num_of_elem %d, elem remain %d msg_index %u",
 		 cdata->num_elems, cdata->elems_remaining, cdata->msg_index);
 
-	/* set the fragment position, data offset and config data size */
+	/*
+	 * The total fragmented-transfer size is kept per instance in
+	 * mod->runtime_params_size; a file-scope static would be shared across
+	 * all module_adapter components and corrupted by interleaved transfers.
+	 */
 	if (!cdata->msg_index) {
-		size = cdata->num_elems + cdata->elems_remaining;
-		data_offset_size = size;
+		mod->runtime_params_size = cdata->num_elems + cdata->elems_remaining;
+		data_offset_size = mod->runtime_params_size;
 		if (cdata->elems_remaining)
 			pos = MODULE_CFG_FRAGMENT_FIRST;
 		else
 			pos = MODULE_CFG_FRAGMENT_SINGLE;
 	} else {
-		data_offset_size = size - (cdata->num_elems + cdata->elems_remaining);
+		data_offset_size = mod->runtime_params_size -
+			(cdata->num_elems + cdata->elems_remaining);
 		if (cdata->elems_remaining)
 			pos = MODULE_CFG_FRAGMENT_MIDDLE;
 		else

src/include/module/module/base.h

@@ -203,6 +203,13 @@ struct processing_module {
 	struct userspace_context *user_ctx;
 	struct k_mem_domain *mdom;
 #endif /* CONFIG_USERSPACE */
+
+	/* total size of a fragmented runtime-params (get/set) transfer, kept
+	 * per instance so concurrent transfers to different components do not
+	 * corrupt each other's reassembly state. Appended here to avoid shifting
+	 * the offsets of the fields above.
+	 */
+	uint32_t runtime_params_size;
 #endif /* SOF_MODULE_PRIVATE */
 };