Skip to content

Commit 75afcee

Browse files
author
Jyri Sarha
committed
topology2: Remove lifetime and shared -bytes_requirement widget attributes
Remove tokens lifetime_heap_bytes_requirement and shared_bytes_requirement and turn interim_bytes_requirement back into heap_bytes_requirement. These new types are not after all needed. The vregions code can handle the division between lifetime linear allocs and traditional interim heap autonomously. And shared memory does not need to be separately configured, vregion_alloc_coherent_align() can allocate shared memory from the same heap. Fixes: 83390bd ("topology2: Add lifetime and shared -bytes_requirement widget attributes") Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
1 parent b1c674a commit 75afcee

2 files changed

Lines changed: 5 additions & 28 deletions

File tree

tools/topology/topology2/include/common/tokens.conf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ Object.Base.VendorToken {
2828
scheduler_domain 418
2929
domain_id 419
3030
stack_bytes_requirement 420
31-
interim_heap_bytes_requirement 421
32-
lifetime_heap_bytes_requirement 422
33-
shared_bytes_requirement 423
31+
heap_bytes_requirement 421
3432
}
3533

3634
"2" {
@@ -68,7 +66,7 @@ Object.Base.VendorToken {
6866
}
6967

7068
"7" {
71-
name "asrc"
69+
name "asrc"
7270
rate_out 321
7371
operation_mode 323
7472
}

tools/topology/topology2/include/components/widget-common.conf

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -149,33 +149,12 @@ DefineAttribute."stack_bytes_requirement" {
149149
token_ref "comp.word"
150150
}
151151

152-
## Interim Heap size requirement in bytes for this component.
153-
## Used for resources that may change in size or be freed during the lifetime of the component.
154-
## In practice this means anything allocated outside module's init() call-back.
155-
DefineAttribute."interim_heap_bytes_requirement" {
156-
# Token set reference name and type
157-
token_ref "comp.word"
158-
}
159-
160-
## Lifetime heap memory allocation requirement in bytes for this component.
161-
## This token's value indicates the amount of allocated memory needed at component init phase
162-
## and used over the lifetime of the component until the component is destroyed.
163-
## In practice this means anything allocated in init() call-back.
164-
DefineAttribute."lifetime_heap_bytes_requirement" {
165-
# Token set reference name and type
166-
token_ref "comp.word"
167-
}
168-
169-
## Shared memory allocation requirement in bytes for this component.
170-
## This token's value indicates the amount of shared memory the component may need to allocated.
171-
## Shared memory may be shared to other components.
172-
DefineAttribute."shared_bytes_requirement" {
152+
## Heap size requirement in bytes for this component.
153+
DefineAttribute."heap_bytes_requirement" {
173154
# Token set reference name and type
174155
token_ref "comp.word"
175156
}
176157

177158
# These default values are here until we have measured module specific numbers
178159
stack_bytes_requirement 8192
179-
interim_heap_bytes_requirement 8192
180-
lifetime_heap_bytes_requirement 16384
181-
shared_bytes_requirement 4096
160+
heap_bytes_requirement 24576

0 commit comments

Comments
 (0)