Skip to content

Commit 96fd5e6

Browse files
committed
lib_manager,module_adapter: add debug traces for openmodule loading
Add temporary diagnostic traces to help debug openmodule llext loading: - lib_manager.c: log module name, entry point, type and adapter ops before module_adapter_new_ext() - module_adapter.c: log extended_init flag and spec.size before init_data, and interface->init pointer before module_init() - module_adapter_ipc4.c: log cfg size, pointer and base/full cfg sizes in module_adapter_init_data() These traces use comp_cl_err/tr_err so they appear on the serial console without needing a full mtrace session.
1 parent a487502 commit 96fd5e6

3 files changed

Lines changed: 15 additions & 1 deletion

File tree

src/audio/module_adapter/module_adapter.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,8 @@ struct comp_dev *module_adapter_new_ext(const struct comp_driver *drv,
266266
#if CONFIG_IPC_MAJOR_4
267267
dst->ext_data = &ext_data;
268268
#endif
269+
comp_cl_err(drv, "DBG adapter_new: extended_init=%d spec.size=%zu",
270+
config->ipc_extended_init, spec.size);
269271
ret = module_adapter_init_data(dev, dst, config, &spec);
270272
if (ret) {
271273
comp_err(dev, "%d: module init data failed",
@@ -304,6 +306,8 @@ struct comp_dev *module_adapter_new_ext(const struct comp_driver *drv,
304306
#endif
305307

306308
/* Init processing module */
309+
comp_cl_err(drv, "DBG adapter_new: calling module_init, interface->init=%p",
310+
interface->init);
307311
ret = module_init(mod);
308312
if (ret) {
309313
comp_err(dev, "%d: module initialization failed",

src/audio/module_adapter/module_adapter_ipc4.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,9 @@ int module_adapter_init_data(struct comp_dev *dev,
130130
assert(dev->drv->type == SOF_COMP_MODULE_ADAPTER);
131131
cfg = (const struct ipc4_base_module_extended_cfg *)args->data;
132132

133+
comp_err(dev, "DBG init_data: cfgsz=%zu cfg=%p base_cfg_sz=%zu full_cfg_sz=%zu",
134+
cfgsz, cfg, sizeof(cfg->base_cfg), sizeof(*cfg));
135+
133136
if (cfg == NULL)
134137
return -EINVAL;
135138
if (cfgsz < sizeof(cfg->base_cfg))

src/library_manager/lib_manager.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,12 @@ static struct comp_dev *lib_manager_module_create(const struct comp_driver *drv,
652652
return NULL;
653653
}
654654

655-
switch (lib_manager_get_module_type(desc, mod)) {
655+
enum buildinfo_mod_type mod_type = lib_manager_get_module_type(desc, mod);
656+
657+
tr_err(&lib_manager_tr, "DBG create: mod='%s' entry=%#lx type=%d",
658+
mod->name, (unsigned long)module_entry_point, mod_type);
659+
660+
switch (mod_type) {
656661
case MOD_TYPE_LLEXT:
657662
agent = NULL;
658663
ops = (const struct module_interface *)module_entry_point;
@@ -683,6 +688,8 @@ static struct comp_dev *lib_manager_module_create(const struct comp_driver *drv,
683688
if (comp_set_adapter_ops(drv, ops) < 0)
684689
goto err;
685690

691+
tr_err(&lib_manager_tr, "DBG create: calling module_adapter_new_ext, ops=%p extended_init=%d",
692+
ops, config->ipc_extended_init);
686693
dev = module_adapter_new_ext(drv, config, spec, adapter_priv, userspace);
687694
if (!dev)
688695
goto err;

0 commit comments

Comments
 (0)