Skip to content

Commit f28ac10

Browse files
committed
tools: topology2: move deepbuffer defaults to separate file
Follow similar split between defaults and defitinions for deep buffer as has been used for Bluetooth, HDMI and other optional features features. This fixes a regression in commit b6ee409 ("Topology2: Add sof-ptl-rt712-l3-rt1320-l3/-4ch support"). This commit changed the defaults to match DSP topology of cavs-sdw.conf and broke topologies based on cavs-rt5682.conf. cavs-rt5682.conf had correct settings, but these were ignored as deep-buffer.conf is included in wrong order. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
1 parent 14ea703 commit f28ac10

8 files changed

Lines changed: 19 additions & 9 deletions

File tree

tools/topology/topology2/cavs-mixin-mixout-efx-hda.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<include/components/tdfb.conf>
2+
<deep-buffer-default.conf>
23

34
Define {
45
ANALOG_PLAYBACK_PCM 'Analog Playback'

tools/topology/topology2/cavs-mixin-mixout-hda.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<include/components/tdfb.conf>
2+
<deep-buffer-default.conf>
23

34
Define {
45
ANALOG_PLAYBACK_PCM 'Analog Playback'

tools/topology/topology2/cavs-nocodec.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
<output_audio_format.conf>
5353
<dmic-default.conf>
5454
<ssp-default.conf>
55+
<deep-buffer-default.conf>
5556

5657
Define {
5758
MCLK 24576000

tools/topology/topology2/cavs-rt5682.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
<dmic-default.conf>
4646
<hdmi-default.conf>
4747
<bt-default.conf>
48+
<deep-buffer-default.conf>
4849
<input_pin_binding.conf>
4950
<output_pin_binding.conf>
5051
<input_audio_format.conf>

tools/topology/topology2/cavs-sdw.conf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@ Define {
7070
DEEP_BUFFER_PIPELINE_SRC 'mixin.15.1'
7171
DEEP_BUFFER_PIPELINE_SINK 'mixout.1.1'
7272
DEEP_BUFFER_PCM_NAME 'Deepbuffer Jack Out'
73+
DEEP_BUFFER_PIPELINE_ID_2 16
74+
DEEP_BUFFER_PCM_ID_2 35
75+
DEEP_BUFFER_PIPELINE_SRC_2 'mixin.16.1'
76+
DEEP_BUFFER_PIPELINE_SINK_2 'mixout.21.1'
77+
DEEP_BUFFER_PCM_NAME_2 'Deepbuffer Amps'
7378
SDW_JACK_OUT_STREAM 'SDW0-Playback'
7479
SDW_JACK_IN_STREAM 'SDW0-Capture'
7580
SDW_JACK_OUT_BE_ID 0

tools/topology/topology2/cavs-src-mixin-mixout-hda.conf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
<deep-buffer-default.conf>
2+
13
Define {
24
ANALOG_PLAYBACK_PCM 'Analog Playback'
35
ANALOG_CAPTURE_PCM 'Analog Capture'
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# default settings for Deep Buffer Speaker
2+
Define {
3+
DEEP_BUF_SPK false
4+
DEEP_BUF_JACK_RATE 48000
5+
6+
DEEP_BUFFER_PCM_NAME 'Deepbuffer Jack Out'
7+
DEEP_BUFFER_PCM_NAME_2 'Deepbuffer Amps'
8+
}

tools/topology/topology2/platform/intel/deep-buffer.conf

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
Define {
2-
DEEP_BUF_SPK false
3-
DEEP_BUF_JACK_RATE 48000
4-
}
51

62
Object.Pipeline.deepbuffer-playback [
73
{
@@ -126,11 +122,6 @@ Object.Base.route [
126122
IncludeByKey.DEEP_BUF_SPK {
127123
"true" {
128124
Define {
129-
DEEP_BUFFER_PIPELINE_ID_2 16
130-
DEEP_BUFFER_PCM_ID_2 35
131-
DEEP_BUFFER_PIPELINE_SRC_2 'mixin.16.1'
132-
DEEP_BUFFER_PIPELINE_SINK_2 'mixout.21.1'
133-
DEEP_BUFFER_PCM_NAME_2 'Deepbuffer Amps'
134125
SPEAKER_PCM_CORE_ID 0
135126
}
136127

0 commit comments

Comments
 (0)