Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are they enabled by default? Maybe the default should be changed - that's what we're relying on not to have to set all unneeded Kconfig options to "n" explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lyakh That should be also done, but currently Zephyr CI relies on these, so somebody who knows where to change the CI tests needs to do the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kv2019i just need to remove https://github.com/zephyrproject-rtos/zephyr/blob/617b71bc174be034b6b910792ea922c47b568068/soc/intel/intel_adsp/Kconfig.defconfig#L39-L42 . I'm not even sure we need
CONFIG_CONSOLE. Just have tried disabling both of them and removing https://github.com/zephyrproject-rtos/zephyr/blob/617b71bc174be034b6b910792ea922c47b568068/soc/intel/intel_adsp/Kconfig.defconfig#L36-L37 and https://github.com/zephyrproject-rtos/zephyr/blob/617b71bc174be034b6b910792ea922c47b568068/soc/intel/intel_adsp/ace/Kconfig.defconfig.series#L53-L58 and the logging is still workingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kv2019i how about zephyrproject-rtos/zephyr#94931 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack @lyakh . Commented on the Zephyr item. I think this is good for SOF, but I was referring to Zephyr CI. But if ok to them (and they can enable winconsole logs in their test builds), then that should work.