Skip to content

Module api: various fixes and developments #10223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 11 commits into from
Oct 7, 2025
Merged

Module api: various fixes and developments #10223

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae351ee
alloc: Add rmalloc_align() function
Sep 4, 2025
7cc4a37
cmocka: Prepare cmocka tests for rmalloc and rmalloc_align
Sep 4, 2025
66ce358
testbench: library: Prepare for rmalloc_align() usage
Sep 4, 2025
e766d25
modules: alloc API: Use rmalloc() instead of rbmalloc()
Sep 3, 2025
fda4ef7
modules: Better mod_alloc_align() failure prints
Sep 2, 2025
7fffe2c
ipc4: helper: Print module IDs as hex
Sep 2, 2025
49f5d6e
modules: mod_alloc: mod_alloc size and alignment parameter to size_t
Sep 12, 2025
efd4119
module: Add mod_balloc() and mod_balloc_aling() functions
Sep 28, 2025
5b2b540
module: Move container_get() after MEM_API_CHECK_THREAD()
Sep 30, 2025
a719c1b
module: Make mod_balloc() and mod_alloc() inline functions
Sep 30, 2025
dbe5520
module: Make mod_zalloc() inline function
Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/audio/module_adapter/module/generic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,7 @@ void *mod_alloc_align(struct processing_module *mod, uint32_t size, uint32_t ali
}

/* Allocate memory for module */
if (alignment)
ptr = rballoc_align(SOF_MEM_FLAG_USER, size, alignment);
else
ptr = rballoc(SOF_MEM_FLAG_USER, size);
ptr = rmalloc_align(SOF_MEM_FLAG_USER, size, alignment);

@lgirdwood lgirdwood Oct 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the rballoc() atm whilst VMH is updated.

@jsarha jsarha Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now also mod_balloc() which uses rballoc as a backend. Going to rballoc() alone will break the CI if conbined with module conversions. Its only a oneliner the change the backend when we are ready for it.


if (!ptr) {
comp_err(mod->dev, "failed to allocate memory.");
Expand Down