Skip to content

tools: topology2: move deepbuffer defaults to separate file #10226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 2 commits into from
Sep 10, 2025
Merged

tools: topology2: move deepbuffer defaults to separate file #10226

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79c5873
tools: topology2: move deepbuffer defaults to separate file
kv2019i Sep 9, 2025
4dd67e9
tools: topology2: change the default deep buffer speaker PCM name
kv2019i Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/topology/topology2/cavs-sdw.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Define {
DEEP_BUFFER_PCM_ID_2 35

@kv2019i kv2019i Sep 9, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos in git commit, will fix:

  • this also changes the defaults, need to address that (not just SDW)
  • will need to add a note this will not change the name for old I2S topologies (these have been shipping for some time and will be a bigger problem if the PCM name changes)

DEEP_BUFFER_PIPELINE_SRC_2 'mixin.16.1'
DEEP_BUFFER_PIPELINE_SINK_2 'mixout.21.1'
DEEP_BUFFER_PCM_NAME_2 'Deepbuffer Amps'
DEEP_BUFFER_PCM_NAME_2 'Deepbuffer Speaker'

@lgirdwood lgirdwood Sep 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we are doing more of a mechanical move in this PR, but I think it makes sense to look at our _ID_n and align them with a string name.

SDW_JACK_OUT_STREAM 'SDW0-Playback'
SDW_JACK_IN_STREAM 'SDW0-Capture'
SDW_JACK_OUT_BE_ID 0
Expand Down
2 changes: 1 addition & 1 deletion tools/topology/topology2/platform/intel/deep-buffer-default.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ Define {
DEEP_BUF_JACK_RATE 48000

DEEP_BUFFER_PCM_NAME 'Deepbuffer Jack Out'
DEEP_BUFFER_PCM_NAME_2 'Deepbuffer Amps'
DEEP_BUFFER_PCM_NAME_2 'Deepbuffer Speaker'
}
Loading