Logging: API Breaking change: Pass log level to logging callback

Users will need to update their logging callbacks accordingly.

Author: theuni

example/calculator.cpp

@@ -37,9 +37,9 @@ class InitImpl : public Init
     }
 };
 
-static void LogPrint(bool raise, const std::string& message)
+static void LogPrint(mp::LogLevel log_level, const std::string& message)
 {
-    if (raise) throw std::runtime_error(message);
+    if (log_level == mp::LogLevel::Exception) throw std::runtime_error(message);
     std::ofstream("debug.log", std::ios_base::app) << message << std::endl;
 }
 

example/example.cpp

@@ -35,9 +35,9 @@ static auto Spawn(mp::EventLoop& loop, const std::string& process_argv0, const s
     return std::make_tuple(mp::ConnectStream<InitInterface>(loop, fd), pid);
 }
 
-static void LogPrint(bool raise, const std::string& message)
+static void LogPrint(mp::LogLevel log_level, const std::string& message)
 {
-    if (raise) throw std::runtime_error(message);
+    if (log_level == mp::LogLevel::Exception) throw std::runtime_error(message);
     std::ofstream("debug.log", std::ios_base::app) << message << std::endl;
 }
 

example/printer.cpp

@@ -32,9 +32,9 @@ class InitImpl : public Init
     std::unique_ptr<Printer> makePrinter() override { return std::make_unique<PrinterImpl>(); }
 };
 
-static void LogPrint(bool raise, const std::string& message)
+static void LogPrint(mp::LogLevel log_level, const std::string& message)
 {
-    if (raise) throw std::runtime_error(message);
+    if (log_level == mp::LogLevel::Exception) throw std::runtime_error(message);
     std::ofstream("debug.log", std::ios_base::app) << message << std::endl;
 }
 

include/mp/proxy-io.h

@@ -107,7 +107,7 @@ enum class LogLevel {
     Exception,
 };
 
-using LogFn = std::function<void(bool raise, std::string message)>;
+using LogFn = std::function<void(LogLevel level, std::string message)>;
 
 class Logger
 {
@@ -134,7 +134,7 @@ class Logger
 
     ~Logger() noexcept(false)
     {
-        if (enabled()) m_fn(m_log_level == LogLevel::Exception, m_buffer.str());
+        if (enabled()) m_fn(m_log_level, m_buffer.str());
     }
 
     template <typename T>

test/mp/test/test.cpp

@@ -60,9 +60,9 @@ class TestSetup
 
     TestSetup(bool client_owns_connection = true)
         : thread{[&] {
-              EventLoop loop("mptest", [](bool raise, const std::string& log) {
-                  std::cout << "LOG" << raise << ": " << log << "\n";
-                  if (raise) throw std::runtime_error(log);
+              EventLoop loop("mptest", [](mp::LogLevel log_level, const std::string& log) {
+                  std::cout << "LOG" << (int)log_level << ": " << log << "\n";
+                  if (log_level == mp::LogLevel::Exception) throw std::runtime_error(log);
               });
               auto pipe = loop.m_io_context.provider->newTwoWayPipe();