lint fixes

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>

Author: jku

tests/test_updater_delegation_graphs.py

@@ -136,7 +136,9 @@ def _assert_files_exist(self, roles: Iterable[str]) -> None:
         """Assert that local metadata files match 'roles'"""
         expected_files = [f"{role}.json" for role in roles]
         found_files = [
-            e.name for e in os.scandir(self.metadata_dir) if e.is_file() and e.name != ".lock"
+            e.name
+            for e in os.scandir(self.metadata_dir)
+            if e.is_file() and e.name != ".lock"
         ]
 
         self.assertListEqual(sorted(found_files), sorted(expected_files))

tests/test_updater_ng.py

@@ -158,7 +158,9 @@ def _assert_files_exist(self, roles: Iterable[str]) -> None:
         """Assert that local metadata files match 'roles'"""
         expected_files = [f"{role}.json" for role in roles]
         found_files = [
-            e.name for e in os.scandir(self.client_directory) if e.is_file() and e.name != ".lock"
+            e.name
+            for e in os.scandir(self.client_directory)
+            if e.is_file() and e.name != ".lock"
         ]
 
         self.assertListEqual(sorted(found_files), sorted(expected_files))
@@ -375,10 +377,16 @@ def test_parallel_updaters(self) -> None:
         ]
 
         p1 = subprocess.Popen(
-            command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, cwd=project_root
+            command,
+            stdout=subprocess.PIPE,
+            stderr=subprocess.PIPE,
+            cwd=project_root,
         )
         p2 = subprocess.Popen(
-            command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, cwd=project_root
+            command,
+            stdout=subprocess.PIPE,
+            stderr=subprocess.PIPE,
+            cwd=project_root,
         )
 
         stdout1, stderr1 = p1.communicate()
@@ -393,6 +401,7 @@ def test_parallel_updaters(self) -> None:
                 f"\nprocess 2 stderr: \n{stderr2.decode()}"
             )
 
+
 if __name__ == "__main__":
     utils.configure_test_logging(sys.argv)
     unittest.main()

tests/test_updater_top_level_update.py

@@ -94,7 +94,9 @@ def _assert_files_exist(self, roles: Iterable[str]) -> None:
         """Assert that local metadata files match 'roles'"""
         expected_files = [f"{role}.json" for role in roles]
         found_files = [
-            e.name for e in os.scandir(self.metadata_dir) if e.is_file() and e.name != ".lock"
+            e.name
+            for e in os.scandir(self.metadata_dir)
+            if e.is_file() and e.name != ".lock"
         ]
 
         self.assertListEqual(sorted(found_files), sorted(expected_files))

tuf/ngclient/updater.py

@@ -78,6 +78,7 @@
 try:
     # advisory file locking for posix
     import fcntl
+
     def _lock_file(f: IO) -> None:
         if f.writable():
             fcntl.lockf(f, fcntl.LOCK_EX)
@@ -87,7 +88,7 @@ def _lock_file(f: IO) -> None:
     import msvcrt
 
     def _lock_file(f: IO) -> None:
-        # On Windows we lock bytes, not the file
+        # On Windows we lock a byte range and file must not be empty
         f.write(b"\0")
         f.flush()
         f.seek(0)
@@ -163,7 +164,6 @@ def __init__(
             self._persist_root(self._trusted_set.root.version, bootstrap)
             self._update_root_symlink()
 
-
     @contextlib.contextmanager
     def _lock_metadata(self) -> Iterator[None]:
         """Context manager for locking the metadata directory."""