Skip to content

Commit 44ac98f

Browse files
lroolleclaude
andcommitted
fix: address review — verify-job auth+retry, reflow llms.txt, changelog flag
- nightly verify: ghcr login + 3-attempt retry per tag; a tripwire that itself flakes trains people to ignore red - llms.txt: one backtick span per command, no line-wrapped flags - CHANGELOG: --add-host host.docker.internal:host-gateway, not the truncated form Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 8385510 commit 44ac98f

3 files changed

Lines changed: 26 additions & 7 deletions

File tree

.github/workflows/nightly-images.yml

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,15 +208,32 @@ jobs:
208208
needs: [resolve-versions, build-base, build-rust]
209209
runs-on: ubuntu-latest
210210
steps:
211+
- name: Log in to Container Registry
212+
uses: docker/login-action@v3
213+
with:
214+
registry: ${{ env.REGISTRY }}
215+
username: ${{ github.actor }}
216+
password: ${{ secrets.GITHUB_TOKEN }}
217+
211218
# Outcome tripwire: assert the artifacts exist, not that the build
212219
# steps exited 0. A green run with an unpullable tag is a lie.
220+
# Small retry absorbs registry eventual-consistency right after push —
221+
# a tripwire that itself flakes trains people to ignore red.
213222
- name: Assert all nightly tags resolve
214223
run: |
215224
set -euo pipefail
216225
stamp="${{ needs.resolve-versions.outputs.stamp }}"
217226
for tag in nightly "nightly-${stamp}" nightly-rust "nightly-${stamp}-rust"; do
218-
docker manifest inspect "ghcr.io/thevibeworks/deva:${tag}" >/dev/null
219-
echo "ok: ${tag}"
227+
for attempt in 1 2 3; do
228+
if docker manifest inspect "ghcr.io/thevibeworks/deva:${tag}" >/dev/null; then
229+
echo "ok: ${tag}"
230+
continue 2
231+
fi
232+
echo "attempt ${attempt} failed for ${tag}; retrying in 10s" >&2
233+
sleep 10
234+
done
235+
echo "error: ghcr.io/thevibeworks/deva:${tag} does not resolve after push" >&2
236+
exit 1
220237
done
221238
222239
summary:

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3636
`HTTP(S)_PROXY` forwarded to `docker build` via BuildKit predefined
3737
ARGs with localhost (and authenticated `user:pass@localhost`) proxies
3838
rewritten to `host.docker.internal` plus an explicit
39-
`--add-host host-gateway` mapping for native Linux Engine; npm version
39+
`--add-host host.docker.internal:host-gateway` mapping for native
40+
Linux Engine; npm version
4041
resolution goes straight to registry.npmjs.org instead of honoring
4142
`.npmrc` mirror overrides, degrading to warn-and-fallback on registry
4243
outages; proxy credentials are redacted from all build/version logs

llms.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@
66

77
deva.sh is a single entry point installed on the host; agents run inside
88
`ghcr.io/thevibeworks/deva` images (`:latest`, `:rust` for stable, `:nightly`,
9-
`:nightly-rust` refreshed daily). Agent-level permission prompts are disabled by
10-
design (`claude --dangerously-skip-permissions`, `codex
11-
--dangerously-bypass-approvals-and-sandbox`, `gemini --yolo`, `grok
12-
--always-approve`) — isolation comes from Docker, not permission theater. Auth
9+
`:nightly-rust` refreshed daily). Agent-level permission prompts are disabled
10+
by design — isolation comes from Docker, not permission theater:
11+
`claude --dangerously-skip-permissions`,
12+
`codex --dangerously-bypass-approvals-and-sandbox`,
13+
`gemini --yolo`, and `grok --always-approve`. Auth
1314
lives in per-agent config homes under `~/.config/deva/` with OAuth (default) or
1415
API-key modes per agent; nothing crosses the host boundary except what you
1516
mount. Known sharp edge: mounting `/var/run/docker.sock` is host-root with

0 commit comments

Comments
 (0)