Commit 711005f
committed
fix: surface docker's error when it rejects a .deva mount
A .deva VOLUME docker refuses made deva.sh die silently -- "Creating
persistent container: <name>" and nothing else. Under set -euo pipefail
a failing command-substitution assignment aborts AT the assignment, so
docker_exit=$? and the entire error block below it were dead code on
the one path they exist for.
Keep the assignment left of `||` to suspend set -e and capture the real
exit; the existing handler then prints docker's own stderr.
Repro: .deva with VOLUME=/tmp:/mnt/bad:rx
before: exit 125, no message
after: exit 1, "docker: Error response from daemon: invalid mode: rx"
The ephemeral path was already safe (if ! docker ...).
Closes #4841 parent 5776806 commit 711005f
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3950 | 3950 | | |
3951 | 3951 | | |
3952 | 3952 | | |
3953 | | - | |
3954 | | - | |
| 3953 | + | |
| 3954 | + | |
| 3955 | + | |
| 3956 | + | |
| 3957 | + | |
| 3958 | + | |
3955 | 3959 | | |
3956 | 3960 | | |
3957 | 3961 | | |
| |||
0 commit comments