Commit d8ce2e7
committed
fix: --dry-run must not pull images or rewrite the resolved tag
check_image ran unconditionally, so a dry run pulled a multi-GB image and,
when the requested tag was missing, its availability fallback rewrote
DEVA_DOCKER_TAG -- making --dry-run report a tag the user never asked for.
CI caught it as a precedence-test failure that could not reproduce locally:
:rust is pullable, so an earlier case pulled it, and the following
`-p cloak` case then failed to pull :cloak (not published yet), found the
freshly-pulled rust locally, and "resolved" to rust. The assertion was
right; the dry run was lying.
Resolution is what --dry-run reports; availability is a launch-time
concern. Skipping check_image on dry runs also makes the precedence
contract testable without any registry state -- the suite now passes with
docker entirely absent.
Refs #4561 parent a90ffc9 commit d8ce2e7
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3958 | 3958 | | |
3959 | 3959 | | |
3960 | 3960 | | |
3961 | | - | |
| 3961 | + | |
| 3962 | + | |
| 3963 | + | |
| 3964 | + | |
| 3965 | + | |
3962 | 3966 | | |
3963 | 3967 | | |
3964 | 3968 | | |
| |||
0 commit comments