docs: codex --browser-mcp clarifications; USER_VOLUMES debug guard - #398
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR closes #397 by clarifying how Codex --browser-mcp works (in-container Chromium, not host Chrome/plugin mounts) and by preventing deva.sh --debug output from erroring under set -u when USER_VOLUMES is empty.
Changes:
- Document that Codex
--browser-mcpuses an isolated Chromium inside the container and that the macOS Codex desktop Chrome plugin is not a viable mount target. - Add a session-only override example to disable
mcp_servers.node_repl. - Guard
USER_VOLUMESexpansion in--debugoutput to avoid nounset/empty-array issues on older Bash versions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/troubleshooting.md | Adds --browser-mcp clarifications and an additional session override example. |
| docs/how-it-works.md | Clarifies browser wiring differences and explicitly notes the desktop plugin is not mountable into the Linux container. |
| deva.sh | Adjusts --debug output to safely print USER_VOLUMES under set -u when empty. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- document that the Codex desktop Chrome plugin is host-only (app
resources, native messaging manifest, extension host binary) and
cannot be mounted into the Linux container
- add mcp_servers.node_repl.enabled=false session-override example
- fix: guard empty USER_VOLUMES debug output under set -u
(bare ${arr[*]} crashes on bash < 4.4)
Close #397
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lroolle
force-pushed
the
docs/browser-mcp-397
branch
from
July 8, 2026 03:21
118546b to
bb82d1c
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #397
🤖 Generated with Claude Code