Skip to content

Minor changes to connection icon 13788#14254

Merged
gregorbg merged 9 commits into
thewca:mainfrom
simonkellly:connect-ui-tweak
May 26, 2026
Merged

Minor changes to connection icon 13788#14254
gregorbg merged 9 commits into
thewca:mainfrom
simonkellly:connect-ui-tweak

Conversation

@simonkellly
Copy link
Copy Markdown
Member

Fixes #13788

image image

Comment thread config/locales/fi.yml Outdated
Copy link
Copy Markdown
Member

@gregorbg gregorbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, super happy with the code, thank you for diving into NextJS!

Regarding the actual screenshots: I feel that the small indicator bubble still has two problems:

  1. On desktop, it is extremely tiny compared to the huge font
  2. The horizontal gap between dot and text is too small

What do you think? Are you happy with the visuals as they are now? Then we can proceed with merging. Otherwise, please play around with the layout of the "dot plus text" to your hearts desire and let me know when you think it's polished!

@simonkellly
Copy link
Copy Markdown
Member Author

image

Potentially something like this?

@gregorbg
Copy link
Copy Markdown
Member

gregorbg commented May 8, 2026

Cool! I would love some input from other folks, but I really like the vibe. My two cents [consider this my taste opinion as an individual, not instructions as a Team Leader]:

  1. The colorful badge is stealing visual attention from the actual heading. Move it right to where the "Show combined results" button is
  2. Will the written content of the badge include the full "Lost connection, results are not being updated" i18n string? That might be a bit too much...

Other opinions warmly welcome, I'm not a designer by any means 😅

@FinnIckler
Copy link
Copy Markdown
Member

I would move it next to the header, but not floating right like the toggle

@simonkellly
Copy link
Copy Markdown
Member Author

Having played around with it a bit, putting it on the right with the actions makes the layout more consistent especially at smaller screen sizes with the way the current layout is setup. Potentially it could be moved around some more but would likely require optimising the layout for smaller screens further.

image image image

Comment thread next-frontend/src/components/live/LiveUpdatingResultsTable.tsx Outdated
Comment thread next-frontend/src/components/live/ConnectionPulse.tsx Outdated
Comment thread next-frontend/src/components/live/ConnectionPulse.tsx Outdated
@gregorbg
Copy link
Copy Markdown
Member

Kindly ping @simonkellly

@simonkellly
Copy link
Copy Markdown
Member Author

simonkellly commented May 26, 2026

Current appearance, reverted the bold text on the badge so that it just uses the normal badge

image

@simonkellly
Copy link
Copy Markdown
Member Author

simonkellly commented May 26, 2026

image

Went for just putting the component twice in the correct locations rather than a more complex solution

@gregorbg gregorbg merged commit fabec45 into thewca:main May 26, 2026
4 checks passed
@simonkellly simonkellly deleted the connect-ui-tweak branch May 27, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Connected, results are being updated" changes

3 participants