Modify edit profile form by requiring edit reason for each field#14331
Open
danieljames-dj wants to merge 3 commits into
Open
Modify edit profile form by requiring edit reason for each field#14331danieljames-dj wants to merge 3 commits into
danieljames-dj wants to merge 3 commits into
Conversation
maxidragon
reviewed
May 12, 2026
| gender={value} | ||
| onChange={onValueChange} | ||
| /> | ||
| <EditReasonField |
Member
There was a problem hiding this comment.
What do you think about not requiring a reason for gender change?
Member
Author
There was a problem hiding this comment.
That's a really good point, but I like to take it up in a follow-up PR in a different way. This PR aims to have text field for all the reasons, and the improvements for each of them will be a separate problem to solve.
For DOB, instead of not making reason mandatory, I prefer giving user the option to tick a checkbox which says that they agree that this change must be done, [...]. This way we will get an extra validation from user that they are finen with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in the edit profile form we have a single edit reason field for all the requests together. This PR targets at having separate edit reason fields for each change in the frontend. (In the backend it will merge all the edit reasons to a single string temporarily, but later this will be a column in the database - in a follow-up PR (not a huge change in backend though, I can do it in the same PR if needed))
Pros of this change:
Cons of this change: