Fix LiteLLM reasoning_content handling#741
Open
cnYui wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThinkingPartcontent intomessage.reasoning_contentfor the LiteLLM provider.TextPartoutput inmessage.contentwithout embedding<think>...</think>blocks.reasoning_contentwhen building LiteLLMModelResponseobjects.Context
The provider previously formatted structured assistant content with
format_content_as_string(). For outputs containingThinkingPart, that produced content like<think>reasoning</think>\nanswer, which made reasoning text appear inmessage.contentand left LiteLLM callers without a cleanreasoning_contentfield.This is related to #684, but this PR is scoped to the cookbook LiteLLM custom provider rather than the hosted OpenAI-compatible API.
Test Plan
uv run pytest tinker_cookbook/third_party/litellm/provider_test.py -quv run ruff check tinker_cookbook/third_party/litellm/uv run pyright tinker_cookbook/third_party/litellmgit diff --check HEAD~1..HEAD