Skip to content

recipes: route run-artifact I/O through Storage#761

Open
derek-tml wants to merge 6 commits into
gh/derek-tml/12/basefrom
gh/derek-tml/12/head
Open

recipes: route run-artifact I/O through Storage#761
derek-tml wants to merge 6 commits into
gh/derek-tml/12/basefrom
gh/derek-tml/12/head

Conversation

@derek-tml
Copy link
Copy Markdown
Collaborator

@derek-tml derek-tml commented Jun 2, 2026

Stack from ghstack (oldest at bottom):

Migrate sweep result collection, the SDFT benchmark and continual-learning
scripts, and the true-thinking-score scripts off pathlib/open() to
storage_from_uri/TrainingRunStore so their outputs land on cloud roots
too. Also fixes a percent-encoding bug when discovering sweep runs whose
names contain '=' (e.g. lr=1e-4).

Co-authored-by: Cursor cursoragent@cursor.com

[ghstack-poisoned]
@derek-tml
Copy link
Copy Markdown
Collaborator Author

@codex review

@derek-tml derek-tml marked this pull request as ready for review June 2, 2026 05:48
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6cea02aa1b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tinker_cookbook/recipes/chat_sl/sweep/results.py Outdated
derek-tml added 2 commits June 1, 2026 22:52
[ghstack-poisoned]
[ghstack-poisoned]
@derek-tml
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

derek-tml added 3 commits June 1, 2026 23:42
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant