π‘οΈ Sentinel: [HIGH] Fix DoS vulnerability via missing execution boundaries#51
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: External operations, specifically
ShellTool.run(shell command execution) andAgentConnector.chat(network requests via Axios), lacked strict execution boundaries (timeouts and buffer limits). This allowed for hanging commands, excessive output generation, or stalled network requests to cause resource exhaustion or Denial of Service (DoS).π― Impact: Agentic operations are susceptible to malicious or errant long-running processes or large outputs that can consume memory or block the event loop, causing the SDK to hang indefinitely and eventually crash or deny service.
π§ Fix: Always set strict limits on external invocations. We've introduced
timeout: 30000andmaxBuffer: 1024 * 1024 * 10limits for child processes (execAsync) inShellTool, and added atimeout: 30000on external API connections (Axios) inAgentConnector.β Verification: Code compiles (
npm run build) and test suite fully passes (npm run test). Functionality is unaffected while enforcing necessary boundaries. Logged this critical learning in.jules/sentinel.md.PR created automatically by Jules for task 10791582806879901041 started by @thirdbase1