chore: Return 4xx if invalid contract or chain in API call (#527)

* chore: Return 4xx if invalid contract or chain in API call

* fix await

Author: arcoraven

src/server/routes/backend-wallet/transfer.ts

@@ -90,10 +90,10 @@ export async function transfer(fastify: FastifyInstance) {
 
         const balance = await sdk.getBalance(walletAddress);
 
-        if (balance.value.lt(normalizedValue)) {
+        if (balance.value.lte(normalizedValue)) {
           throw createCustomError(
             "Insufficient balance",
-            StatusCodes.BAD_GATEWAY,
+            StatusCodes.BAD_REQUEST,
             "INSUFFICIENT_BALANCE",
           );
         }

src/server/utils/chain.ts

@@ -3,12 +3,16 @@ import {
   getChainByChainIdAsync,
   getChainBySlugAsync,
 } from "@thirdweb-dev/chains";
+import { StatusCodes } from "http-status-codes";
 import { getConfig } from "../../utils/cache/getConfig";
 import { networkResponseSchema } from "../../utils/cache/getSdk";
 import { logger } from "../../utils/logger";
+import { createCustomError } from "../middleware/error";
 
 /**
  * Given a valid chain name ('Polygon') or ID ('137'), return the numeric chain ID.
+ *
+ * @throws if the chain is invalid or deprecated.
  */
 export const getChainIdFromChain = async (input: string): Promise<number> => {
   const inputSlug = input.toLowerCase();
@@ -40,21 +44,27 @@ export const getChainIdFromChain = async (input: string): Promise<number> => {
     }
   }
 
-  if (!isNaN(inputId)) {
-    // Fetch by chain ID.
-    const chainData = await getChainByChainIdAsync(inputId);
-    if (chainData && chainData.status !== "deprecated") {
-      return chainData.chainId;
-    }
-  } else {
-    // Fetch by chain name.
-    const chainData = await getChainBySlugAsync(inputSlug);
-    if (chainData && chainData.status !== "deprecated") {
-      return chainData.chainId;
+  // Fetch by chain ID or slug.
+  // Throw if the chain is invalid or deprecated.
+  try {
+    const chain = !isNaN(inputId)
+      ? await getChainByChainIdAsync(inputId)
+      : await getChainBySlugAsync(inputSlug);
+
+    if (chain.status === "deprecated") {
+      throw createCustomError(
+        `Chain ${input} is deprecated`,
+        StatusCodes.BAD_REQUEST,
+        "INVALID_CHAIN",
+      );
     }
-  }
 
-  throw new Error(
-    `Invalid or deprecated chain. Please confirm this is a valid chain: https://thirdweb.com/${input}`,
-  );
+    return chain.chainId;
+  } catch (e) {
+    throw createCustomError(
+      `Chain ${input} is not found`,
+      StatusCodes.BAD_REQUEST,
+      "INVALID_CHAIN",
+    );
+  }
 };

src/utils/cache/getContract.ts

@@ -1,3 +1,5 @@
+import { StatusCodes } from "http-status-codes";
+import { createCustomError } from "../../server/middleware/error";
 import { getSdk } from "./getSdk";
 
 interface GetContractParams {
@@ -15,6 +17,14 @@ export const getContract = async ({
 }: GetContractParams) => {
   const sdk = await getSdk({ chainId, walletAddress, accountAddress });
 
-  // We don't need to maintain cache for contracts because sdk handles it already
-  return sdk.getContract(contractAddress);
+  try {
+    // SDK already handles caching.
+    return await sdk.getContract(contractAddress);
+  } catch (e) {
+    throw createCustomError(
+      `Contract metadata could not be resolved: ${e}`,
+      StatusCodes.BAD_REQUEST,
+      "INVALID_CONTRACT",
+    );
+  }
 };