fix: /reset-nonces endpoint allows deleting nonce state without resyncing (#836)

* chore: Allow deleting stored nonces without resyncing yet

* rename

* also delete nonce-history

Author: arcoraven

src/server/routes/backend-wallet/reset-nonces.ts

@@ -21,6 +21,11 @@ const requestBodySchema = Type.Object({
     description:
       "The backend wallet address to reset nonces for. Omit to reset all backend wallets.",
   }),
+  syncOnchainNonces: Type.Boolean({
+    description:
+      "Resync nonces to match the onchain transaction count for your backend wallets. (Default: true)",
+    default: true,
+  }),
 });
 
 const responseSchema = Type.Object({
@@ -61,7 +66,11 @@ export const resetBackendWalletNoncesRoute = async (
       },
     },
     handler: async (req, reply) => {
-      const { chainId, walletAddress: _walletAddress } = req.body;
+      const {
+        chainId,
+        walletAddress: _walletAddress,
+        syncOnchainNonces,
+      } = req.body;
 
       // If chain+wallet are provided, only process that wallet.
       // Otherwise process all used wallets that has nonce state.
@@ -70,19 +79,21 @@ export const resetBackendWalletNoncesRoute = async (
           ? [{ chainId, walletAddress: getAddress(_walletAddress) }]
           : await getUsedBackendWallets();
 
-      const RESYNC_BATCH_SIZE = 50;
-      for (let i = 0; i < backendWallets.length; i += RESYNC_BATCH_SIZE) {
-        const batch = backendWallets.slice(i, i + RESYNC_BATCH_SIZE);
+      const BATCH_SIZE = 50;
+      for (let i = 0; i < backendWallets.length; i += BATCH_SIZE) {
+        const batch = backendWallets.slice(i, i + BATCH_SIZE);
 
         // Delete nonce state for these backend wallets.
         await deleteNoncesForBackendWallets(backendWallets);
 
-        // Resync nonces for these backend wallets.
-        await Promise.allSettled(
-          batch.map(({ chainId, walletAddress }) =>
-            syncLatestNonceFromOnchain(chainId, walletAddress),
-          ),
-        );
+        if (syncOnchainNonces) {
+          // Resync nonces for these backend wallets.
+          await Promise.allSettled(
+            batch.map(({ chainId, walletAddress }) =>
+              syncLatestNonceFromOnchain(chainId, walletAddress),
+            ),
+          );
+        }
       }
 
       reply.status(StatusCodes.OK).send({

src/shared/db/wallets/wallet-nonce.ts

@@ -10,6 +10,7 @@ import { normalizeAddress } from "../../utils/primitive-types";
 import { redis } from "../../utils/redis/redis";
 import { thirdwebClient } from "../../utils/sdk";
 import { updateNonceMap } from "./nonce-map";
+import { nonceHistoryKey } from "../../../worker/tasks/nonce-health-check-worker";
 
 /**
  * Get all used backend wallets.
@@ -45,7 +46,7 @@ export const getUsedBackendWallets = async (
 
 /**
  * The "last used nonce" stores the last nonce submitted onchain.
- * Example: "25"
+ * Example: 25 -> nonce 25 is onchain, nonce 26 is unused or inflight.
  */
 export const lastUsedNonceKey = (chainId: number, walletAddress: Address) =>
   `nonce:${chainId}:${normalizeAddress(walletAddress)}`;
@@ -260,6 +261,7 @@ export async function deleteNoncesForBackendWallets(
     lastUsedNonceKey(chainId, walletAddress),
     recycledNoncesKey(chainId, walletAddress),
     sentNoncesKey(chainId, walletAddress),
+    nonceHistoryKey(chainId, walletAddress),
   ]);
   await redis.del(keys);
 }

src/worker/tasks/nonce-health-check-worker.ts

@@ -116,7 +116,10 @@ async function getCurrentNonceState(
   };
 }
 
-function nonceHistoryKey(walletAddress: Address, chainId: number) {
+/**
+ * Stores a list of onchain vs sent nonces to check if the nonce is stuck over time.
+ */
+export function nonceHistoryKey(chainId: number, walletAddress: Address) {
   return `nonce-history:${chainId}:${getAddress(walletAddress)}`;
 }
 
@@ -128,15 +131,15 @@ async function getHistoricalNonceStates(
   chainId: number,
   periods: number,
 ): Promise<NonceState[]> {
-  const key = nonceHistoryKey(walletAddress, chainId);
+  const key = nonceHistoryKey(chainId, walletAddress);
   const historicalStates = await redis.lrange(key, 0, periods - 1);
   return historicalStates.map((state) => JSON.parse(state));
 }
 
 // Update nonce history
 async function updateNonceHistory(walletAddress: Address, chainId: number) {
   const currentState = await getCurrentNonceState(walletAddress, chainId);
-  const key = nonceHistoryKey(walletAddress, chainId);
+  const key = nonceHistoryKey(chainId, walletAddress);
 
   await redis
     .multi()