Skip to content

Remove Hardcoded Values and Make Codebase Client-Agnostic#35

Merged
FacuSentena merged 4 commits into
mainfrom
feature/constants-removal
Jan 9, 2026
Merged

Remove Hardcoded Values and Make Codebase Client-Agnostic#35
FacuSentena merged 4 commits into
mainfrom
feature/constants-removal

Conversation

@FacuSentena
Copy link
Copy Markdown
Collaborator

Remove Hardcoded Values and Make Codebase Client-Agnostic

Documentation Updates

  • README.md - Added Databricks Deployment section with secrets, cluster env vars, and GitHub secrets
  • docs/combined_documentation.md - Updated Configuration Reference with required variables
  • env.example - Updated with all required variables and sample values

Configuration Reference

Layer Variables
Databricks Secrets SNOWFLAKE_ACCOUNT, SNOWFLAKE_USER, SNOWFLAKE_PASSWORD, DATABRICKS_HOST, DATABRICKS_CLIENT_ID, DATABRICKS_CLIENT_SECRET
Cluster Env Vars UC_CATALOG, UC_SCHEMA, SNOWFLAKE_DATABASE, SNOWFLAKE_SCHEMA
GitHub Secrets DATABRICKS_HOST, DATABRICKS_CLIENT_ID, DATABRICKS_CLIENT_SECRET, DATABRICKS_CLUSTER_ID, UC_CATALOG, DEVS_GROUP

Breaking Changes

⚠️ Required Action: The following must be set before deployment:

  1. Databricks secrets scope with 6 credentials
  2. Cluster environment variables with 4 config values
  3. GitHub secrets with 6 values (for CI/CD)
  4. DEVS_GROUP must exist in Databricks Admin Console

Testing

  • make translate runs successfully (39 results, 0 errors)
  • All validation errors throw clear messages
  • Documentation is complete

@FacuSentena FacuSentena merged commit 02aac77 into main Jan 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant